user/listenbrainz-mpd: new package #3517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
q66
reviewed
Jan 24, 2025
|
squash your commits and rebase your branch |
|
Alright, will do ASAP when I get home. |
JetpackJackson
force-pushed
the
add-listenbrainz-mpd
branch
from
1a93cac to
df9764a
Compare
|
This is embarrassing, I think I messed up the squash and rebase... I hope I didn't break anything, if I did break something I want to fix it ASAP... :( |
|
you can just fix your branch and then push --force into it, starting over does not get you anything |
JetpackJackson
force-pushed
the
add-listenbrainz-mpd
branch
from
efa35ae to
df9764a
Compare
q66
reviewed
Jan 25, 2025
JetpackJackson
force-pushed
the
add-listenbrainz-mpd
branch
from
df9764a to
a92728c
Compare
JetpackJackson
force-pushed
the
add-listenbrainz-mpd
branch
from
f7a8dec to
e9c125e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a new package called listenbrainz-mpd, which submits songs played by mpd to ListenBrainz for the user to track what songs they have listened to. This is my first contribution, so if I have made any errors, please let me know so that I can fix them ASAP.
Before submitting, I tested that the package built properly, that it worked in a Chimera Linux VM (ie it submitted songs using a working config file), and I formatted the template.py file with Black.
Checklist
Before this pull request is reviewed, certain conditions must be met.
The following must be true for all changes:
The following must be true for template/package changes:
The following must be true for new package submissions: